[server] Handle missing database file ids for file paths #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
force-pushed
the
handle_missing_file_id
branch
2 times, most recently
from
58b3bda to
fab98d9
Compare
csordasmarton
force-pushed
the
handle_missing_file_id
branch
from
fab98d9 to
41d10bf
Compare
bruntib
requested changes
Nov 18, 2021
|
|
||
| return self.__files | ||
|
|
||
| @property | ||
| def trimmed_files(self) -> Set[str]: |
There was a problem hiding this comment.
It is a little misleading, because this function doesn't return trimmed file paths necessarily, unless we call trim() earlier. This strange behavior also applies to File class too. Do we need to store trimmed file paths separately for some performance reasons? Couldn't we store the original paths and trim them in this function instead?
bruntib
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.