[cli] Fix html output of CodeChecker parse #3524
Conversation
csordasmarton
commented
Nov 29, 2021
csordasmarton
commented
csordasmarton
added
CLI 💻
|
I can confirm that the patch works :) My repository is private where I use codechecker so unfortunately I cannot share the results. |
|
Preliminary tests suggest that this is indeed okay. I'm doing a full run of the analysis in the CI with CodeChecker built from the request branch, stay tuned! 🎉 |
| self, | ||
| reports: List[Report] | ||
| ): | ||
| ) -> Tuple[HTMLReports, FileSources]: | ||
| """ Get html reports from the given reporst. |
There was a problem hiding this comment.
| """ Get html reports from the given reporst. | |
| """ Get HTML reports from the given reports. |
| #include "f.h" | ||
|
|
||
| int b() { | ||
| foo(); |
| <key>check_name</key> | ||
| <string>clang-diagnostic-return-type</string> | ||
| <key>description</key> | ||
| <string>non-void function does not return a value</string> |
There was a problem hiding this comment.
† So this warning disappears from one of the TUs?
| if re.search("<td file=", line): | ||
| report_count += 1 | ||
|
|
||
| self.assertEqual(report_count, 6) |
There was a problem hiding this comment.
† And then it should be 5, right?
(I want to go for an odd number, so any chance of this mystical duplication issue coming up later would clearly be different, because it would end up the counts being even.)
There was a problem hiding this comment.
This became 4 now, which is also an even number. 🙁
The idea was that only 1 out of the 2 TUs will have a return X;, the other won't, so we get (for the project) 1 "non-void function does not return a value" warning. Previously we had 2, now we have 0, the parity is the same, so we still can't catch a "duplication" mistake.
|
Full CI run from my side confirms the output structure (and the size) of the report directory is sensible again, thank you. |
csordasmarton
force-pushed
the
fix_html_output_for_includes
branch
from
58825b1 to
8038db8
Compare
| if re.search("<td file=", line): | ||
| report_count += 1 | ||
|
|
||
| self.assertEqual(report_count, 4) |
There was a problem hiding this comment.
This became 4 now, which is also an even number. 🙁
The idea was that only 1 out of the 2 TUs will have a return X;, the other won't, so we get (for the project) 1 "non-void function does not return a value" warning. Previously we had 2, now we have 0, the parity is the same, so we still can't catch a "duplication" mistake.
There was a problem hiding this comment.
@whisperity Fixed.
csordasmarton
force-pushed
the
fix_html_output_for_includes
branch
from
8038db8 to
0b77928
Compare
