[cmd] Allow escaping : in run names with \:
#3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain scenarios, the run name might contain a `:` character that does NOT separate a tag from a name. Commands such as `server` and `cmd results` accept `:` as a literal in the name, but `cmd diff` previously cut it as the "run tag" separator.
whisperity
added
enhancement 🌟
CLI 💻
|
@csordasmarton Should, or could, this go into 6.18.1? It is not a bugfix in the strictest terms, but does lessen a weird discrepancy in operation. (It would also help a pet project I was working on recently to have the initial release with it auto-suggesting |
whisperity
added a commit
to whisperity/CodeChecker-Action
that referenced
this pull request
Dec 24, 2021
This reverts commit d0c913f. As Ericsson/codechecker#3536 got merged, we can return to using `:`.
whisperity
added a commit
to whisperity/CodeChecker-Action
that referenced
this pull request
Dec 24, 2021
This reverts commit d0c913f. As Ericsson/codechecker#3536 got merged, we can return to using `:`.
whisperity
added a commit
to whisperity/CodeChecker-Action
that referenced
this pull request
Dec 24, 2021
This reverts commit d0c913f. As Ericsson/codechecker#3536 got merged, we can return to using `:`.
whisperity
added a commit
to whisperity/CodeChecker-Action
that referenced
this pull request
Dec 24, 2021
This reverts commit d0c913f. As Ericsson/codechecker#3536 got merged, we can return to using `:`.
csordasmarton
added a commit
to csordasmarton/codechecker
that referenced
this pull request
Jan 5, 2022
…diff [cmd] Allow escaping `:` in run names with `\:`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain scenarios, the run name might contain a
:character that does NOT separate a tag from a name.Commands such as
serverandcmd resultsaccept:as a literal in the name, butcmd diffpreviously cut it as the "run tag" separator.