[test] Fix non-deterministic test in plist to html #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In one test case related to plist to html conversion we iterate over multiple plist files, we convert it to HTML files and we also skip duplicates. So let's assume that I have two plist files a.plist and b.plist and both plist files contains the same results. Let's assume that I process the a.plist file first and convert the reports to HTML. Next if I process the b.plist I will do not generate HTML file from it because the same reports are already in the HTML file what we generated for a.plist and we do not generate empty HTML files anymore. To solve this problem in the test case we will check if we have report, and in this case the HTML file has to be exist otherwise it hasn't.
bruntib
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one test case related to plist to html conversion we iterate
over multiple plist files, we convert it to HTML files and we also
skip duplicates.
So let's assume that I have two plist files a.plist and b.plist and both
plist files contains the same results. Let's assume that I process the a.plist
file first and convert the reports to HTML. Next if I process the b.plist I will
do not generate HTML file from it because the same reports are already in the HTML
file what we generated for a.plist and we do not generate empty HTML files anymore.
To solve this problem in the test case we will check if we have report, and in this
case the HTML file has to be exist otherwise it hasn't.