[server] Fix suppressing bug on the server #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change seems reasonable for me, but I can't reproduce the issue. The report is suppressed for me even before this change. |
|
Make sure two things:
Also check the example in the modified test case. |
It is possible that the start line and end line of a bug reported by the
analyzer are different.
Example:
```cpp
int main()
{
// codechecker_suppress [all] This will not be suppressed because of a bug.
int x = 1 /
0;
return x;
}
```
In the above example the bug start line is where `x` variable is declared and
the end line is in the next line.
On the server we stored the start line as the line where the report can be
found but for suppression we checked whether there is a source code comment
above the end line. So if someone inserted a source code comment above the
start line the server hasn't suppressed that report.
With this patch we will solve this problem and we will check the source code
comment above the start line and not the end line.
csordasmarton
force-pushed
the
fix_suppression_in_server
branch
from
e4d4adf to
362e6a8
Compare
|
Please use older client/server than 6.18.0. >=6.18.0 releases contained another bug (#3576) which hided this problem. |
bruntib
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the start line and end line of a bug reported by the analyzer are different.
Example:
In the above example the bug start line is where
xvariable is declared and the end line is in the next line.On the server we stored the start line as the line where the report can be found but for suppression we checked whether there is a source code comment above the end line. So if someone inserted a source code comment above the start line the server hasn't suppressed that report.
With this patch we will solve this problem and we will check the source code comment above the start line and not the end line.