[fix] Fix HTML generation for CodeChecker cmd diff command #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
added
CLI 💻
If the diff contained reports from multiple source files (e.g.: a.cpp + b.cpp) the `CodeChecker cmd diff` command in HTML format generated HTML files for each source file but inserted the same list of reports in all of the HTML files. This can be easily reproduced by creating two source files and insert a report in both of the source file. Create a compilation database with 2 translation units, analyze this project and use the diff command to generate HTML output files to a run which is empty. This patch will solve this problem and will insert only those reports to a generated HTML files which are really related to that file.
csordasmarton
force-pushed
the
fix_diff_html_output
branch
from
6d28872 to
319b67c
Compare
bruntib
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the diff contained reports from multiple source files (e.g.: a.cpp + b.cpp)
the
CodeChecker cmd diffcommand in HTML format generated HTML files foreach source file but inserted the same list of reports in all of the HTML files.
This can be easily reproduced by creating two source files and insert a report in both
of the source file. Create a compilation database with 2 translation units, analyze
this project and use the diff command to generate HTML output files to a run which is
empty.
This patch will solve this problem and will insert only those reports to a generated
HTML files which are really related to that file.