[fix] Fix the prepare debug scripts #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are multiple changes in this commit: - Expect 'compilation_database.json' instead of 'compile_cmd.json' in failed zips. - Uplift the 'compiler_info.json' preparation to the 'new' format. - Use the expected compiler for '--ctu-collect'. Since these were broken for quite a while, and these debug scripts are not for production use, I'm not willing to create tests for this change.
steakhal
force-pushed
the
fix-debug-scripts
branch
from
b33f994 to
f612d56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple changes in this commit:
failed zips.
Since these were broken for quite a while, and these debug scripts are
not for production use, I'm not willing to create tests for this change.