[gui] Update run filter when setting the filter options #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only the run history was affected, when the analyzed before/after options were set. This resulted in a confusing view when the displayed run entries last analyzed date would show outside of the specified date. This patch fixes this issue as it will hide those runs where the before/after criteria is not met.
|
I plan to extend this pr with the proper GUI tests. |
bruntib
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the run history was affected, when the analyzed before/after options were set. This resulted in a confusing view when the displayed run entries last analyzed date would show outside of the specified date.
This patch fixes this issue as it will hide those runs where the before/after criteria is not met.
fixes #3962