[bugfix] Allow the disabling of statisticsbased checkers #3972
Conversation
bruntib
added
CLI 💻
Szelethus
changed the title
| @@ -94,6 +98,19 @@ def parse_clang_help_page( | |||
| return res | |||
|
|
|||
|
|
|||
| def _is_user_disabled_checker(checker, ordered_checkers): | |||
| """ | |||
| This function returns True if the given statistics-based checker is | |||
There was a problem hiding this comment.
Seems like this is not a statisticsbased specific function. If it is important for those checkers specifically, document it why. I'd expect to see something like
"Since these checkers can be enabled through -e/--enable AND --stats, we need special handling for them to make sure -d/--disable overwrite --stats"
| if 'stats_enabled' in args: | ||
| # In some Clang versions these checkers may be in some checker | ||
| # group (e.g. alpha...), so let's find the actual checker name | ||
| # first. |
There was a problem hiding this comment.
I see what you wanted to say, but its a little sloppy. How about this:
"In some Clang versions, statisticsbased checkers are in the alpha package (alpha.statisticsbased), and maybe not in others. Lets figure out the actual checker name first"
| handler.set_checker_enabled(unchecked_return_value) | ||
|
|
||
| # Statistics collector checkers must be explicitly disabled | ||
| # as they trash the output. |
There was a problem hiding this comment.
You should also state that their job was done anyway in a preceding analysis phase. Otherwise I enjoy the sh!ttalk :)
bruntib
force-pushed
the
stat_checker_disable
branch
from
5175e8c to
70cae53
Compare
| handler.set_checker_enabled(unchecked_return_value) | ||
|
|
||
| # Statistics collector checkers must be explicitly disabled as they | ||
| # trash the output. Thise checkers are executed in a preceding analysis |
There was a problem hiding this comment.
| # trash the output. Thise checkers are executed in a preceding analysis | |
| # trash the output. These checkers are executed in a preceding analysis |
There was a problem hiding this comment.
Also, almost there, how about you end the sentence with "so they are not needed here."
When --stats flag is given to then command "CodeChecker analyze" then two statistics-based checkers are enabled by default: - statisticsbased.SpecialReturnValue - statisticsbased.UncheckedReturnValue These can't be disabled if --stats flag is used. This patch fixes this bug: now users can disable either statistics-based checker, even if --stats is used.
bruntib
force-pushed
the
stat_checker_disable
branch
from
70cae53 to
ed5c0be
Compare
When --stats flag is given to "CodeChecker analyze" these two statistics-based checkers are enabled by default:
These can't be disabled even with
-d/--disableif they were enabled by--stats.This patch fixes this bug: now users can disable either statistics-based checker, even if --stats is used.