[enhancement] --cppcheckargs flag was missing #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
added
enhancement 🌟
CLI 💻
dkrupp
approved these changes
Sep 28, 2023
|
@bruntib please rebase this PR and then we can merge. |
Analyzer config options can be forwarded to the analyzers by --saargs and --tidyargs flags. This was missing for Cppcheck, so --cppcheckargs flag has now been introduced. Fixes Ericsson#3936
jmalmari
reviewed
Nov 9, 2023
| @@ -225,6 +226,8 @@ def construct_analyzer_cmd(self, result_handler): | |||
|
|
|||
| analyzer_cmd.append('--plist-output=' + str(output_dir)) | |||
|
|
|||
| analyzer_cmd.extend(config.analyzer_extra_arguments) | |||
There was a problem hiding this comment.
Looks like this line was already present a few lines up.
There was a problem hiding this comment.
Good point, thanks for the comment!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyzer config options can be forwarded to the analyzers by --saargs and --tidyargs flags. This was missing for Cppcheck, so --cppcheckargs flag has now been introduced.
Fixes #3936