[fix] Refine when a report is regarded as outstanding for tags #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szelethus
force-pushed
the
tag_fix_attempt
branch
from
64139c7 to
5ed1365
Compare
Szelethus
force-pushed
the
tag_fix_attempt
branch
from
5ed1365 to
0ca663e
Compare
bruntib
requested changes
Sep 12, 2023
| @@ -70,6 +70,14 @@ | |||
| SQLITE_MAX_COMPOUND_SELECT = 500 | |||
|
|
|||
|
|
|||
| def dumpSql(q): | |||
There was a problem hiding this comment.
Intentionally, this is meant to be a debug function for occasional use.
Despite only two lines of code, this patch is many things all in once: * We fix a bug where diffing tags returned unexpected (and percieved to be incorrect) results, * We redefine what we expect from diffing tags, * We redefine the expected heaviour around review status rules. Previously, we regarded review status rules are a timeless property, but what is even more true, we didn't really know what we expect from them when it came to diffing tags. This lead to confusion on the developer side and on the user side as well, and lead to whack-a-mole issues and patches like Ericsson#3675, that was more driven by what users expected from this feature than a comprehensive plan. This is okay -- the review status feature and the tag feature grew in their own world, and nobody can be faulted for being on top of these features having a very solid specifications right out of the gate. This patch solved this issue. From this point on, our stance is the following: when we diff runs, we always check whether a report is outstanding _at the time of the query_, and for diffing tags or timestamps, we check whether a report is outstanding _at the time of the tag/timestamp_. A user-facing documentation is written in Ericsson#4006, and can be previewed here: https://github.com/Szelethus/codechecker/blob/diff_docs_rewrite/docs/web/diff.md
Szelethus
force-pushed
the
tag_fix_attempt
branch
from
0ca663e to
ffd6567
Compare
bruntib
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite only two lines of code, this patch is many things all in once:
be incorrect) results,
Previously, we regarded review status rules are a timeless property, but
what is even more true, we didn't really know what we expect from them
when it came to diffing tags. This lead to confusion on the developer
side and on the user side as well, and lead to whack-a-mole issues and
patches like #3675, that was more driven by what users expected from
this feature than a comprehensive plan.
This is okay -- the review status feature and the tag feature grew in
their own world, and nobody can be faulted for being on top of these
features having a very solid specifications right out of the gate. This
patch solved this issue.
From this point on, our stance is the following: when we diff runs, we
always check whether a report is outstanding at the time of the query,
and for diffing tags or timestamps, we check whether a report is
outstanding at the time of the tag/timestamp.
A user-facing documentation is written in #4006, and can be previewed
here:
https://github.com/Szelethus/codechecker/blob/diff_docs_rewrite/docs/web/diff.md