Parse file speed up #4000
Merged
Parse file speed up #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cservakt
added
WIP 💣
cservakt
force-pushed
the
parse-speed-up
branch
from
0901a1e to
75a1cdc
Compare
bruntib
requested changes
Sep 8, 2023
| @@ -392,7 +392,22 @@ def get_output_file_path(default_file_name: str) -> Optional[str]: | |||
|
|
|||
| for dir_path, file_paths in report_file.analyzer_result_files(args.input): | |||
| metadata = get_metadata(dir_path) | |||
| for file_path in file_paths: | |||
|
|
|||
| specified_file_paths = None | |||
There was a problem hiding this comment.
I'm not sure if this variable is needed. file_paths could be assigned the new list if any.
| ] if 'tools' in metadata \ | ||
| and len(metadata['tools']) > 0 \ | ||
| and 'result_source_files' in metadata['tools'][0] \ | ||
| else None |
There was a problem hiding this comment.
If this result_source_files section is missing from metadata.json then we could fall back to the slow version by using file_paths again instead of giving no result due to this None value.
cservakt
force-pushed
the
parse-speed-up
branch
from
75a1cdc to
2c2c4a2
Compare
cservakt
force-pushed
the
parse-speed-up
branch
from
2c2c4a2 to
a7879c2
Compare
The feature can be useful to speed up the parse process when you want to parse one or more specified files. The VSCode Plugin also runs the 'parse --file' command, so the correction can solve the slow file verification problem. It uses metadata.json for plist mapping if the result_source_files section is not empty and contains the pairing of source files and plist files. Before the new feature, the process read all existing plist files to find the specified source file's reports.
bruntib
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature can be useful to speed up the parse process when you want to parse one or more specified files. The VSCode Plugin also runs the 'parse --file' command, so the correction can solve the slow file verification problem. It uses metadata.json for plist mapping if the result_source_files section is not empty and contains the pairing of source files and plist files. Before the new feature, the process read all existing plist files to find the specified source file's reports.