[GUI] Unnecessary reports columns #4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cservakt
added
WIP 💣
bruntib
requested changes
Sep 25, 2023
Comment on lines
386
to
396
| this.hasTimeStamp = this.formattedReports.map( | ||
| report => report.timestamp | ||
| ).filter(ts => ts).length | ||
| ? true | ||
| : false; | ||
|
|
||
| this.hasTestCase = this.formattedReports.map( | ||
| report => report.testcase | ||
| ).filter(tc => tc).length | ||
| ? true | ||
| : false; |
There was a problem hiding this comment.
Suggested change
| this.hasTimeStamp = this.formattedReports.map( | |
| report => report.timestamp | |
| ).filter(ts => ts).length | |
| ? true | |
| : false; | |
| this.hasTestCase = this.formattedReports.map( | |
| report => report.testcase | |
| ).filter(tc => tc).length | |
| ? true | |
| : false; | |
| this.hasTimeStamp = | |
| this.formattedReports.some(report => report.timestamp); | |
| this.hasTestCase = | |
| this.formattedReports.some(report => report.testcase); |
May I recommend a shorter implementation?
There was a problem hiding this comment.
Thank you for the suggestion. Using some() method is more stylish solution.
The "timestamp" and "testcase" columns are only needed for a special test case, therefore, they can be removed if their content is completely empty. When the "formattedReports" prop is changed, The values are verified again. If a report had timestamp or testcase, the columns would be displayed again.
cservakt
force-pushed
the
unnecessary-reports-columns
branch
from
8e8426e to
fbf4082
Compare
bruntib
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "timestamp" and "testcase" columns are only needed for a special test case, therefore, they can be removed if their content is completely empty. When the "formattedReports" prop is changed, the values are verified again. If a report had timestamp or testcase, the columns would be displayed again.