Gcc analyzer native support #4030
Conversation
Szelethus
added
analyzer 📈
Szelethus
force-pushed
the
gcc_analyzer_native_support
branch
3 times, most recently
from
84a6396 to
472611b
Compare
| @@ -3,7 +3,8 @@ | |||
| "analyzers": { | |||
| "clangsa": "clang", | |||
| "clang-tidy": "clang-tidy", | |||
| "cppcheck": "cppcheck" | |||
| "cppcheck": "cppcheck", | |||
| "gcc": "g++" | |||
There was a problem hiding this comment.
This is an interesting question, how we could support both gcc and g++. Can this gcc analyzer analyze both .c and .cpp build actions?
There was a problem hiding this comment.
The same thing we do with clang. As I understand, these are functionally the same:
clang++ == clang -x cpp
clang == clang++ -x c
Szelethus
force-pushed
the
gcc_analyzer_native_support
branch
from
472611b to
fdd6a77
Compare
There was a problem hiding this comment.
Nice job!
In general looks good.
- Please fix the binary exploration stuff. that's prohibitive even for the release-candidate
- some error and warning messages look too aggessive
- we will need to categorize the checkers into profiles and severities
- gcc static analyzer is said to be not working very well on c++ code at least in gcc 12. Should we recommend introduce a gcc analyzer option to only analyze c files? https://developers.redhat.com/articles/2022/04/12/state-static-analysis-gcc-12-compiler#
otherwise how the user gets rid off false warnings in C++ files. - also add the gcc analyzer support to this doc https://github.com/Ericsson/codechecker/blob/master/docs/supported_code_analyzers.md
|
I'm afraid you tested an outdated version :^) I'll see to the other comments ASAP. |
Looking at the current version of this PR, messages look right. Do you agree? |
| Config options for gcc. | ||
| """ | ||
| # TODO | ||
| return [] |
There was a problem hiding this comment.
To return an empty list is valid here I think.
Now, I am getting this error:
workspace/test-projects/xerces-c]$ CodeChecker analyzers --analyzer-config gcc
[ERROR 2023-10-16 12:00] - Failed to get analyzer configuration options for 'gcc' analyzer! Please try to upgrade your analyzer version to use this feature.
However not supporting any option is not an error.
CodeChecker should write something like this instead:
No analyzer options supported for gcc.
Szelethus
force-pushed
the
gcc_analyzer_native_support
branch
2 times, most recently
from
f1ae95b to
058ecfe
Compare
I intend to fix that with the alternative solution for #4041 (where we will have at least one analyzer config for each analyzer). |
Szelethus
force-pushed
the
gcc_analyzer_native_support
branch
from
058ecfe to
a6b442e
Compare
Szelethus
force-pushed
the
gcc_analyzer_native_support
branch
from
a6b442e to
0619997
Compare
WIP. Depends on #4011.