[fix] Pass envp to posix_spawn in ld_logger
#4146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szelethus
reviewed
Feb 19, 2024
Comment on lines
-49
to
-54
| /* \ | ||
| Note that envp is not passed through (which would be the environment that \ | ||
| that the process will be spawned it), but is replaced by environ, which is \ | ||
| a global variable that stores our environment. We added quite a few \ | ||
| variables into it, and for some reason, they are not present in envp. \ | ||
| */ \ |
There was a problem hiding this comment.
It was a while since I wrote this, but I recall that some codechecker (CC_*) and logger related variables were not present in envp, but should've been. Can you verify thats not an issue?
There was a problem hiding this comment.
I'm not sure, which environment variable was involved in your case, but this function call blocked the forwarding of all environment variable. I assume, this cc_ was among them too.
whisperity
changed the title
argp to posix_spawn in ld_logger
whisperity
changed the title
argp to posix_spawn in ld_loggerenvp to posix_spawn in ld_logger
whisperity
requested changes
Mar 22, 2024
whisperity
added
the
tools 🛠️
bruntib
force-pushed
the
logger_env_posix_spawn
branch
3 times, most recently
from
f7c5a9a to
5e72ecf
Compare
GNU make 4.3 uses posix_spawn() for initiating recursive make calls in subdirectories: make -C <subdirectory> Since we overwrote posix_spawn() through LD_PRELOAD and we didn't forward environment variables to the subprocess, the build of the submodule didn't get the environment variables set by a Makefile. This commit fixes this issue so the logging phase behaves the same way as the original build. Fixes Ericsson#3860
bruntib
force-pushed
the
logger_env_posix_spawn
branch
from
5e72ecf to
32e4366
Compare
whisperity
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU make 4.3 uses posix_spawn() for initiating recursive make calls in subdirectories:
make -C <subdirectory>
Since we overwrote posix_spawn() through LD_PRELOAD and we didn't forward environment variables to the subprocess, the build of the submodule didn't get the environment variables set by a Makefile. This commit fixes this issue so the logging phase behaves the same way as the original build.
Fixes #3860