Do not allow parse if the <report dir> does not exist #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraz31
force-pushed
the
missing_report_dir_alert
branch
2 times, most recently
from
75a06b2 to
d2f2b0f
Compare
Szelethus
reviewed
Apr 23, 2024
Comment on lines
286
to
289
| for input_path in args.input: | ||
| if not os.path.exists(input_path): | ||
| LOG.error(f"Input path {input_path} does not exist!") | ||
| sys.exit(1) |
There was a problem hiding this comment.
You could consider emitting a warning for all non-existent paths before exiting.
This change prevents the CodeChecker parse command from running if the entered report dir or filepath parameter does not exist. Up until now, the parse command ran with any parameters, reporting zero findings if a wrong parameter was entered. Fixes Ericsson#4186
noraz31
force-pushed
the
missing_report_dir_alert
branch
from
d2f2b0f to
8480c51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents the CodeChecker parse command
from running if the entered report dir or filepath
parameter does not exist.
Up until now, the parse command ran with any parameters,
reporting zero findings if a wrong parameter was entered.
Fixes #4186