Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always pass absolute paths to skip handler #4227

Merged
merged 8 commits into from
May 22, 2024
Merged

Always pass absolute paths to skip handler #4227

merged 8 commits into from
May 22, 2024

Conversation

vodorok
Copy link
Contributor

@vodorok vodorok commented Apr 24, 2024 •
edited
Loading

Fixes #4223

The implemented solution changes compilation actions source members to contain absolute paths.
Consequently, this will result in all should_skip() calls containing absolute paths to the source.

@vodorok vodorok requested a review from bruntib as a code owner April 24, 2024 14:20
@vodorok vodorok added analyzer 📈 Related to the analyze commands (analysis driver) config ⚙️ and removed config ⚙️ labels Apr 24, 2024
@vodorok vodorok changed the title Alway pass absolute paths to skip handler Always pass absolute paths to skip handler Apr 25, 2024
@vodorok vodorok requested review from whisperity and cservakt April 26, 2024 08:26
@vodorok
Add tests
8010476 
Two tests new tests were implemented.
One tests that the "file" entry in a the compile command is relative to
the "directory" entry.
The other is when the "directory" entry is a ".".
@vodorok vodorok force-pushed the abs_path_to_skiphandler branch from 1d167a3 to 8010476 Compare May 9, 2024 11:58
@vodorok vodorok added this to the release 6.24.0 milestone May 9, 2024
@vodorok vodorok self-assigned this May 9, 2024
bruntib
bruntib approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@bruntib bruntib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good patch, however, #4223 works for me even without this patch. What is this PR actually fixing?

@bruntib bruntib merged commit 5bff2ba into Ericsson:master May 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruntib bruntib bruntib approved these changes

@whisperity whisperity Awaiting requested review from whisperity

@cservakt cservakt Awaiting requested review from cservakt

Assignees

@vodorok vodorok

Labels
analyzer 📈 Related to the analyze commands (analysis driver)
Projects
None yet
Milestone
release 6.24.0
Development

Successfully merging this pull request may close these issues.

CodeChecker analyze skip does not work if the file location is relative in the compilation db
2 participants
@vodorok @bruntib