chore(config): [clang-tidy] Update SEI-CERT Guideline mappings #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whisperity
added
analyzer 📈
whisperity
changed the title
whisperity
added
the
RDY-OnHold 🛑
whisperity
force-pushed
the
chore/config/clang-tidy-sei-cert-guideline-mapping
branch
from
c26fe95 to
4bdfe69
Compare
Ensure that checkers that target SEI CERT C & C++ guideline rules and recommendations are appropriately labelled as such: `guideline:sei-cert`, `profile:security`, and the guideline label. In case the checker is implemented through an alias (or even multiple aliases), apply the labels to **only** the **main** checker, and strip the profile and guidelines associations from the aliases. (Due to the lack of proper alias handling in both Clang-Tidy and CodeChecker, firing all aliases would result in multiple detections of the same match.) Ensure, in addition, that `profile:default` and `profile:sensitive` checkers are also always in the more broad superset profiles `profile:sensitive` and `profile:extreme`.
whisperity
force-pushed
the
chore/config/clang-tidy-sei-cert-guideline-mapping
branch
from
4bdfe69 to
a149cbf
Compare
whisperity
removed
the
RDY-OnHold 🛑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
⛔ Blocked by #4224.
Ensure that checkers that target SEI CERT C & C++ guideline rules and recommendations are appropriately labelled as such:
guideline:sei-cert,profile:security, and the guideline label.In case the checker is implemented through an alias (or even multiple aliases), apply the labels to only the main checker, and strip the profile and guidelines associations from the aliases. (Due to the lack of proper alias handling in both Clang-Tidy and CodeChecker, firing all aliases would result in multiple detections of the same match.)
Ensure, in addition, that
profile:defaultandprofile:sensitivecheckers are also always in the more broad superset profilesprofile:sensitiveandprofile:extreme.