Make sure that the Number of runs is displayed correctly #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szelethus
requested changes
May 16, 2024
noraz31
force-pushed
the
fix_number_of_runs
branch
2 times, most recently
from
048b22c to
db38d84
Compare
Szelethus
approved these changes
May 17, 2024
cservakt
reviewed
May 21, 2024
| @@ -3424,10 +3424,24 @@ def removeRun(self, run_id, run_filter): | |||
| # cascades and such. Deleting runs in separate transactions don't | |||
| # exceed a potential statement timeout threshold in a DBMS. | |||
| runs = [] | |||
| run_no = 0 | |||
There was a problem hiding this comment.
I'm not sure run_no is a clear variable name. Maybe deleted_run_cnt or something else would be better.
bruntib
requested changes
May 22, 2024
| # counter is not affected by the exception. | ||
| LOG.warning(f"Suppressed an exception while " | ||
| f"deleting run {run.name}. Error: {e}") | ||
| pass |
There was a problem hiding this comment.
Unnecessary pass statement.
| # expected to never occur, but there have been some rare | ||
| # cases where it occurred due to underlying reasons. | ||
| # Handling it silently ensures that the Number of runs | ||
| # counter is not affected by the exception. |
There was a problem hiding this comment.
One reason of the exception can be an SQL statement timeout while a too large run is being deleted. We should include another TODO here which suggests the catching of SQLAlchemyError instead of the generic Exception when we can make this sure based on the warnings messages below, in the server logs.
In some rare cases, when an error occurs while deleting runs, the number of runs to be deleted is deducted from the "Number of runs" value displayed in the "Products" view, even though some runs do not get deleted. For this reason, the number of runs could go negative upon the next run deletion. This change is to fix this issue.
noraz31
force-pushed
the
fix_number_of_runs
branch
from
db38d84 to
3abcb42
Compare
bruntib
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases, when an error occurs while deleting
runs, the number of runs to be deleted is deducted from
the "Number of runs" value displayed in the
"Products" view, even though some runs do not get
deleted. For this reason, the number of runs could go
negative upon the next run deletion.
This change is to fix this issue.