[cfg] Add setuptools as a dependency #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
added
dev env ⛑️
whisperity
reviewed
Jul 8, 2024
| types-PyYAML==6.0.12.12 | ||
| setuptools==70.2.0 |
There was a problem hiding this comment.
Can you add the closing newline here so this diff stops complaining about it?
bruntib
force-pushed
the
setuptools_dependence
branch
3 times, most recently
from
f811e8b to
eb3b610
Compare
|
Something is wrong here. You seem to have amended a merge commit already on master and made that as the only commit of this patch set? |
Some modules are using setuptools as a 3pp, however, no requirements.txt contains it.
bruntib
force-pushed
the
setuptools_dependence
branch
from
eb3b610 to
ca7f1ad
Compare
|
Thanks, it was a good catch! I don't know, how it happened :) |
cservakt
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some platforms don't come with pre-installed setuptools module. However, some CodeChecker modules need this library as a dependency.
Fixes #4278