[fix] Don't enable checkers by suffix #4307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, checkers can be enabled by checker name prefix. For example, "--enable unix" enables all checkers starting with "unix". However, checkers shouldn't be enabled by suffix match: "--enable Malloc" shouldn't enable "unix.Malloc" checker. The source of the confusion was that having "unix.Stream" checker in the "default" profile also enabled "alpha.unix.Stream", which is not an intended behavior.
bruntib
added
CLI 💻
dkrupp
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, checkers can be enabled by checker name prefix. For example, "--enable unix" enables all checkers starting with "unix". However, checkers shouldn't be enabled by suffix match: "--enable Malloc" shouldn't enable "unix.Malloc" checker.
The source of the confusion was that having "unix.Stream" checker in the "default" profile also enabled "alpha.unix.Stream", which is not an intended behavior.