Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve paths when blaming files #4357

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

tomhughes
Copy link
Contributor

Both git check-ignore and git blame will error if run on a symbolic link, so resolve the path before running them.

@dkrupp dkrupp requested a review from cservakt November 5, 2024 14:21
Copy link
Collaborator

@cservakt cservakt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vodorok vodorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruntib
Copy link
Contributor

bruntib commented Nov 28, 2024

@tomhughes Thanks for the patch. Could you, please, force-push a dummy change, so the test workflow is triggered? For some reason they don't start. Thank you!

Both `git check-ignore` and `git blame` will error if run on
a symbolic link, so resolve the path before running them.
@tomhughes
Copy link
Contributor Author

I've forced a run now - there is one failure but it doesn't look related.

@bruntib bruntib merged commit a3ede93 into Ericsson:master Nov 29, 2024
7 of 8 checks passed
@bruntib bruntib added this to the release 6.25.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants