Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on the latest nightly #17

Merged
merged 5 commits into from
Oct 1, 2021
Merged

Fix compilation on the latest nightly #17

merged 5 commits into from
Oct 1, 2021

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Oct 1, 2021

The feature const_generics was spitted to adt_const_params and generic_const_exprs, see more infor here. So in this PR I replaced const_generics with adt_const_params. But the compiler complains that the feature is incomplete, so I added incomplete_features to allow.

Also I removed extended_key_value_attributes since it was stabilized in 1.54.0.

Fixes #16.

ErnWong
ErnWong previously approved these changes Oct 1, 2021
Copy link
Owner

@ErnWong ErnWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Shatur Shatur requested a review from ErnWong October 1, 2021 23:21
@Shatur
Copy link
Contributor Author

Shatur commented Oct 1, 2021

Fixed other warnings that caused issues with CI.

@ErnWong ErnWong merged commit 0750623 into ErnWong:master Oct 1, 2021
@ErnWong
Copy link
Owner

ErnWong commented Oct 1, 2021

Cheers!

@Shatur Shatur deleted the fix-nightly branch October 2, 2021 08:08
@Shatur
Copy link
Contributor Author

Shatur commented Oct 2, 2021

@ErnWong looks like something wrong with your token for test coverage?

@ErnWong
Copy link
Owner

ErnWong commented Oct 2, 2021

Yeah. If I remember correctly, GitHub Actions doesn't share my test coverage token secret to the test-coverage PR check for forks (I might be wrong - I'll need to double check someday). I also remember reading somewhere that a token isn't actually required for public repos, but last time I tried it, I seemed to had difficulty getting it working without a token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to compile with latest nightly
2 participants