Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Jar for shaded kryo5 has wrong package declaration inside files #870

Closed
leonard84 opened this issue Dec 2, 2021 · 2 comments
Closed

Comments

@leonard84
Copy link

Describe the bug
The sources jar has relocated the source files to the correct package folder, but it didn't modify the package declaration inside the packages.

It is package com.esotericsoftware.kryo; while it should be package com.esotericsoftware.kryo.kryo5;.

This is also the probable cause of an issue with IntelliJ. When both kryo 4 and the shaded kryo5 are used as dependencies, then Intellij has problems jumping to the correct sources.

To Reproduce
Download the jar and look at the sources and see the mismatch

Environment:

  • Kryo Version: 5.2.0

Additional context
This could be solved by modifying the sources before packaging them in the jar, e.g., https://stackoverflow.com/a/2196729/16358266.

@theigl
Copy link
Collaborator

theigl commented Dec 6, 2021

@leonard84: Thanks for the info!

This should be fixable by using the following option for the shade plugin:

https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#shadeSourcesContent

I'll look into this before I release the next minor version.

@theigl
Copy link
Collaborator

theigl commented Dec 8, 2021

Resolved via bc6c8ca.

I'll try to release Kryo 5.2.1 in the coming days.

@theigl theigl closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants