#774 Do not re-use serializers for CompatibleFieldSerializer and TaggedFieldSerializer #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theigl
force-pushed
the
#774-serializer-reuse
branch
from
6266ee5
to
c2bffc7
Compare
…le` and `Tagged` serializers in `ReflectField`
theigl
force-pushed
the
#774-serializer-reuse
branch
from
c2bffc7
to
1dfe700
Compare
…serializer-reuse
theigl
force-pushed
the
#774-serializer-reuse
branch
2 times, most recently
from
4d1c422
to
b5af092
Compare
theigl
changed the title
Compatible and Tagged serializers
theigl
force-pushed
the
#774-serializer-reuse
branch
6 times, most recently
from
0580329
to
9a08a51
Compare
|
@magro: If you have a couple of minutes to spare, please take a look at this PR. This fix should make it into Kryo 5.0.1. I asked Nate for feedback why we always set the |
…le` and `Tagged` serializers in `ReflectField`
theigl
force-pushed
the
#774-serializer-reuse
branch
from
9a08a51
to
fcbf217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #774
Resolves #784
This PR prevents re-using
ReflectFieldserializers when usingCompatibleFieldSerializerandTaggedFieldSerializer.Re-using serializers works for
FieldSerializerbecause it only provides a concretevalueClassfor final field types or iffixedFieldTypesis enabled.CompatibleFieldSerializerandTaggedFieldSerializeralways populate thevalueClasswith the last value they encounter.I'm not fond of this solution but it is the only way to resolve this issue without breaking backwards compatibility.