Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom exception for buffer over/underflow #874

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Custom exception for buffer over/underflow #874

merged 4 commits into from
Jan 20, 2022

Conversation

msx80
Copy link
Contributor

@msx80 msx80 commented Dec 29, 2021

Implements #872

@theigl
Copy link
Collaborator

theigl commented Dec 30, 2021

@msx80: Thanks a lot for the PR!

Please apply mvn formatter:format on the PR, so we can be sure it adheres to the project code style.

Since this is affecting the public API, I'll try to get feedback from the project's original author.

@msx80
Copy link
Contributor Author

msx80 commented Jan 3, 2022

should be ok now

@theigl
Copy link
Collaborator

theigl commented Jan 18, 2022

@msx80: Thank you for your patience!

I finally found the time to get some feedback. We only need one minor change to your PR: Please remove the KryoIOException superclass. We don't really need it at the moment and can add it back anytime, should somebody ask for it. Then I'll merge the PR.

@msx80
Copy link
Contributor Author

msx80 commented Jan 19, 2022

i've removed it, let me know if it's ok thank you :)

@theigl theigl merged commit b1cb816 into EsotericSoftware:master Jan 20, 2022
@theigl
Copy link
Collaborator

theigl commented Jan 20, 2022

Merged, thank you @msx80!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants