Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Benchmarks] Remove transaction size check #3392

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[Benchmarks] Remove transaction size check #3392

merged 2 commits into from
Jun 27, 2024

Conversation

dailinsubjam
Copy link
Contributor

Closes #<ISSUE_NUMBER>

This PR:

  • Removes the assertion of equal transaction size, since in Sequencer we have variant transaction size.

This PR does not:

Key places to review:

@dailinsubjam dailinsubjam merged commit 0d64703 into main Jun 27, 2024
34 of 35 checks passed
@dailinsubjam dailinsubjam deleted the sishan/orchestrator_changes_for_sequencer_compatibility branch June 27, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparr721 jparr721 jparr721 approved these changes

@rob-maron rob-maron rob-maron approved these changes

@elliedavidson elliedavidson Awaiting requested review from elliedavidson

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dailinsubjam @jparr721 @rob-maron