[Marketplace] Builder API adjustments #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliedavidson
approved these changes
Jul 26, 2024
Comment on lines
+243
to
+272
| let start = Instant::now(); | ||
|
|
||
| if let Ok(Ok(urls)) = async_timeout( | ||
| self.builder_timeout, | ||
| self.auction_results_provider | ||
| .fetch_auction_result(block_view), | ||
| ) | ||
| .await | ||
| { | ||
| let mut futures = Vec::new(); | ||
|
|
||
| for url in urls.urls() { | ||
| futures.push(async_timeout( | ||
| self.builder_timeout.saturating_sub(start.elapsed()), | ||
| async { | ||
| let client = crate::builder::v0_3::BuilderClient::new(url); | ||
| client.bundle(*block_view).await | ||
| }, | ||
| )); | ||
| } | ||
|
|
||
| let mut bundles = Vec::new(); | ||
|
|
||
| for bundle in join_all(futures).await { | ||
| match bundle { | ||
| Ok(Ok(b)) => bundles.push(b), | ||
| _ => continue, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This section looks good to me
There was a problem hiding this comment.
Looks fine to me too, though I think it would be nice to have this logic be a separate function. We can make an issue for that/do it later though.
There was a problem hiding this comment.
Yeah, we can do it when implementing this part of the spec:
Query all builders in parallel, have a timeout that is constrained by a max system timeout of 1 second, and a minimum set by 2/3 of the builders, then add 10% additional time for the remaining 1/3 to resolve.
There was a problem hiding this comment.
Although I'm not opposed to factoring it out now, won't take long.
ss-es
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #0000
This PR:
AuctionResultsProviderto transaction task, as it needs to use the builder client, which isn't available inhotshot-typesThis PR does not:
Key places to review:
Everything