Skip to content

Commit

Permalink
Update loggings to make sure builders are run correctly (#1870)
Browse files Browse the repository at this point in the history
Closes #<ISSUE_NUMBER>
<!-- These comments should help create a useful PR message, please
delete any remaining comments before opening the PR. -->
<!-- If there is no issue number make sure to describe clearly *why*
this PR is necessary. -->
<!-- Mention open questions, remaining TODOs, if any -->

### This PR:
* Reapply changes in
#1867, which
was reverted by
#1869.

### This PR does not:
<!-- Describe what is out of scope for this PR, if applicable. Leave
this section blank if it's not applicable -->
<!-- This section helps avoid the reviewer having to needlessly point
out missing parts -->
<!-- * Implement feature 3 because that feature is blocked by Issue 4
-->
<!-- * Implement xyz because that is tracked in issue #123. -->
<!-- * Address xzy for which I opened issue #456 -->

### Key places to review:
<!-- Describe key places for reviewers to pay close attention to -->
<!-- * file.rs, `add_integers` function -->
<!-- Or directly comment on those files/lines to make it easier for the
reviewers -->

<!-- ### How to test this PR:  -->
<!-- Optional, uncomment the above line if this is relevant to your PR
-->
<!-- If your PR is fully tested through CI there is no need to add this
section -->
<!-- * E.g. `just test` -->

<!-- ### Things tested -->
<!-- Anything that was manually tested (that is not tested in CI). -->
<!-- E.g. building/running of docker containers. Changes to docker demo,
... -->
<!-- Especially mention anything untested, with reasoning and link an
issue to resolve this. -->

<!-- Complete the following items before creating this PR -->
<!-- [ ] Issue linked or PR description mentions why this change is
necessary. -->
<!-- [ ] PR description is clear enough for reviewers. -->
<!-- [ ] Documentation for changes (additions) has been updated (added).
-->
<!-- [ ] If this is a draft it is marked as "draft".  -->

<!-- To make changes to this template edit
https://github.com/EspressoSystems/.github/blob/main/PULL_REQUEST_TEMPLATE.md
-->
  • Loading branch information
shenkeyao authored Aug 15, 2024
2 parents 4030ffd + 4755d43 commit 5927593
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions marketplace-builder/src/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -206,26 +206,29 @@ impl BuilderConfig {
let res =
run_non_permissioned_standalone_builder_service(hooks, senders, events_url)
.await;
tracing::error!(?res, "builder service exited");
tracing::error!(?res, "Reserve builder service exited");
if res.is_err() {
panic!("Builder should restart.");
panic!("Reserve builder should restart.");
}
});

tracing::info!("Reserve builder init finished");
} else {
let hooks = hooks::EspressoFallbackHooks { solver_api_url };

async_spawn(async move {
let res =
run_non_permissioned_standalone_builder_service(hooks, senders, events_url)
.await;
tracing::error!(?res, "builder service exited");
tracing::error!(?res, "Fallback builder service exited");
if res.is_err() {
panic!("Builder should restart.");
panic!("Fallback builder should restart.");
}
});

tracing::info!("Fallback builder init finished");
}

tracing::info!("Builder init finished");
Ok(Self {
global_state,
hotshot_events_api_url,
Expand Down

0 comments on commit 5927593

Please sign in to comment.