Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add endpoint for hotshot config and env variables #1481

Merged
merged 16 commits into from
May 20, 2024
Merged

add endpoint for hotshot config and env variables #1481

merged 16 commits into from
May 20, 2024

Conversation

imabdulbasit
Copy link
Contributor

@imabdulbasit imabdulbasit commented May 17, 2024 •
edited
Loading

Closes #1413

This PR:

adds endpoints for

  • hotshot config
  • env vars

This PR does not:

Key places to review:

@imabdulbasit
get hotshot config
0987b2e
@imabdulbasit
env vars
d1e365e 
rm ConfigPersistence

add config module to options

docs
@imabdulbasit imabdulbasit marked this pull request as draft May 17, 2024 00:04
@imabdulbasit imabdulbasit linked an issue May 17, 2024 that may be closed by this pull request
Add endpoint to print HotShotConfig and all env options #1413
Closed
jbearer
jbearer requested changes May 17, 2024
View reviewed changes
Copy link
Member

@jbearer jbearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this! I have wanted this for so long lol

sequencer/src/api/data_source.rs Outdated Show resolved Hide resolved
sequencer/src/api/data_source.rs Outdated Show resolved Hide resolved
sequencer/src/api/endpoints.rs Outdated Show resolved Hide resolved
sequencer/src/api.rs Outdated Show resolved Hide resolved
jbearer
jbearer reviewed May 20, 2024
View reviewed changes
sequencer/src/api/data_source.rs Show resolved Hide resolved
sequencer/src/api/data_source.rs Show resolved Hide resolved
sequencer/src/api/data_source.rs Show resolved Hide resolved
sequencer/src/api/data_source.rs Show resolved Hide resolved
sequencer/src/api/options.rs Outdated Show resolved Hide resolved
jbearer
jbearer reviewed May 20, 2024
View reviewed changes
public-env-vars.toml Outdated Show resolved Hide resolved
public-env-vars.toml Outdated Show resolved Hide resolved
sequencer/api/config.toml Outdated Show resolved Hide resolved
public-env-vars.toml Outdated Show resolved Hide resolved
@imabdulbasit imabdulbasit marked this pull request as ready for review May 20, 2024 19:53
jbearer
jbearer approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@jbearer jbearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to go!

@imabdulbasit imabdulbasit merged commit d782c87 into main May 20, 2024
15 checks passed
@imabdulbasit imabdulbasit deleted the abdul/config branch May 20, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sveitser sveitser sveitser left review comments

@jbearer jbearer jbearer approved these changes

@nomaxg nomaxg Awaiting requested review from nomaxg nomaxg is a code owner

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@tbro tbro Awaiting requested review from tbro tbro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add endpoint to print HotShotConfig and all env options
3 participants
@imabdulbasit @sveitser @jbearer