Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi fees per block (versioned) #1659

Closed
wants to merge 48 commits into from
Closed

multi fees per block (versioned) #1659

wants to merge 48 commits into from

Commits on May 23, 2024

  1. Replace public header fields with getters 

    This will make it easier to keep a somewhat consistent Rust API
even as we add or change various fields in the underlying
representation of the header.
    @jbearer
    jbearer committed May 23, 2024
    Configuration menu
    Copy the full SHA
    0555b0b View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. WIP upgradable types

    @jbearer
    jbearer committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f605483 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. v2

    @imabdulbasit
    imabdulbasit committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    8adbdfd View commit details
    Browse the repository at this point in the history

  2. merge origin/main

    @imabdulbasit
    imabdulbasit committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    365d884 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ab/ver

    @imabdulbasit
    imabdulbasit authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0f225bb View commit details
    Browse the repository at this point in the history

  4. cargo sort

    @imabdulbasit
    imabdulbasit committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    9896587 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. block impls

    @imabdulbasit
    imabdulbasit committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6e2e9e6 View commit details
    Browse the repository at this point in the history

  2. remove unused imports

    @imabdulbasit
    imabdulbasit committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ad046c3 View commit details
    Browse the repository at this point in the history

  3. export types

    @imabdulbasit
    imabdulbasit committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    278f1fb View commit details
    Browse the repository at this point in the history

  4. group imports

    @imabdulbasit
    imabdulbasit committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    82ec12f View commit details
    Browse the repository at this point in the history

  5. v3 header

    @imabdulbasit
    imabdulbasit committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    bcff34a View commit details
    Browse the repository at this point in the history

  6. lint

    @imabdulbasit
    imabdulbasit committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    eac798d View commit details
    Browse the repository at this point in the history

  7. remove v2 header definition

    @imabdulbasit
    imabdulbasit committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    69fce8b View commit details
    Browse the repository at this point in the history

  8. move crates to workspace

    @imabdulbasit
    imabdulbasit committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8819268 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. remove types from sequencer crate

    @imabdulbasit
    imabdulbasit committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4dae934 View commit details
    Browse the repository at this point in the history

  2. group imports

    @imabdulbasit
    imabdulbasit committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    26876bc View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. serialization

    @imabdulbasit
    imabdulbasit committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    aaa6f11 View commit details
    Browse the repository at this point in the history

  2. fix test

    @imabdulbasit
    imabdulbasit committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0fc4398 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. fix deserialization

    @imabdulbasit
    imabdulbasit committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    df2b9b5 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into ab/ver

    @imabdulbasit
    imabdulbasit committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    0dbc44b View commit details
    Browse the repository at this point in the history

  3. cargo sort

    @imabdulbasit
    imabdulbasit committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    43d9331 View commit details
    Browse the repository at this point in the history

  4. lint

    @imabdulbasit
    imabdulbasit committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d68d146 View commit details
    Browse the repository at this point in the history

  5. fix payload::empty()

    @imabdulbasit
    imabdulbasit committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    013a32c View commit details
    Browse the repository at this point in the history

  6. fix: visit_map deserialization

    @imabdulbasit
    imabdulbasit committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    2c28e6c View commit details
    Browse the repository at this point in the history

  7. use serde_json map

    @imabdulbasit
    imabdulbasit committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    daeb6c4 View commit details
    Browse the repository at this point in the history

  8. cargo sort

    @imabdulbasit
    imabdulbasit committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    4815708 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into ab/ver

    @imabdulbasit
    imabdulbasit authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7d197dd View commit details
    Browse the repository at this point in the history

  10. fix ResolvableChainConfigOrVersion deserialization

    @imabdulbasit
    imabdulbasit committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    420af73 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. make FeeInfo iterable 

    still need to update logic where FeeInfo is used in validation
    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    db8698d View commit details
    Browse the repository at this point in the history

  2. make some logic upgradable 

    revert the iterable `FeeInfo`. Currently the compiler is unaware of
header version in `validate_builder_fee` causing compile errors.
    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3ec9924 View commit details
    Browse the repository at this point in the history

  3. type match header version

    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c96744b View commit details
    Browse the repository at this point in the history

  4. get validate_builder_fee in more or less expected form 

    Note that upstream changes to BuilderSignature trait are required in
order for this to compile. Or, we *could* simply bypass the trait.
    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    86279c7 View commit details
    Browse the repository at this point in the history

  5. comment

    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    7079d91 View commit details
    Browse the repository at this point in the history

  6. update validate_proposal

    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    83f4124 View commit details
    Browse the repository at this point in the history

  7. update charge_fee

    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    bf7a814 View commit details
    Browse the repository at this point in the history

  8. update missing_accounts

    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2eba51d View commit details
    Browse the repository at this point in the history

  9. fix fee info serialization for Header::commit()

    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    128f211 View commit details
    Browse the repository at this point in the history

  10. add TODO for dealing w/ ExplorerHeader

    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    cc66f77 View commit details
    Browse the repository at this point in the history

  11. Check that total fee amount is less than base_fee * block_size

    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    dccc122 View commit details
    Browse the repository at this point in the history

  12. add accounts method to IterableFeeInfo

    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    0867660 View commit details
    Browse the repository at this point in the history

  13. AmountOutOfRange should better reflect logic 

    `Vec<FeeInfo>::amount()` will return `None` if any FeeAmount is out of
range or if the sum total of the amounts is out of range. So this
commit updates varient name and `Display` impl to better reflect that.
    @tbro
    tbro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ead3b27 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. add tests for IterableFeeInfo 

    As yet un tested
    @tbro
    tbro committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    8887a6d View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Fix compile errors 

    Except arguments passed to builder signature (waiting on
hotshot). Also move `IterableFeeInfo` trait to types.
    @tbro
    tbro committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f9c2c38 View commit details
    Browse the repository at this point in the history

  2. Move IterableFeeInfo to v3 

    some lints
    @tbro
    tbro committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c3fbfb3 View commit details
    Browse the repository at this point in the history

  3. update Vec<Option<Buildersignature>> to Vec<BuilderSignature> 

    The absence of a builder signature can be represented as an
empty array.
    @tbro
    tbro committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    cc24063 View commit details
    Browse the repository at this point in the history

  4. Update header creation for multiple fees

    @tbro
    tbro committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f3a256f View commit details
    Browse the repository at this point in the history

  5. Less silly way to merge iterators for missing accounts

    @tbro
    tbro committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d710db8 View commit details
    Browse the repository at this point in the history

  6. even less silly

    @tbro
    tbro committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7f1320e View commit details
    Browse the repository at this point in the history