Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marketplace solver rollup registration types #1802

Merged
merged 4 commits into from
Jul 31, 2024
Merged

marketplace solver rollup registration types #1802

merged 4 commits into from
Jul 31, 2024

Conversation

imabdulbasit
Copy link
Contributor

  • adds rollup registration and rollup update types
  • implements commitable trait for these types

@imabdulbasit imabdulbasit changed the title solver types marketplace solver rollup registration types Jul 31, 2024
tbro
tbro reviewed Jul 31, 2024
View reviewed changes
types/src/v0/impls/solver.rs Outdated Show resolved Hide resolved
tbro
tbro reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@tbro tbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable for moving us forward. But I think we will need constructors and getters in the not so distant future. Is that the plan?

types/src/v0/impls/solver.rs Outdated Show resolved Hide resolved
types/src/v0/impls/solver.rs Show resolved Hide resolved
types/src/v0/impls/solver.rs Show resolved Hide resolved
@imabdulbasit
Copy link
Contributor Author

I think this is reasonable for moving us forward. But I think we will need constructors and getters in the not so distant future. Is that the plan?

Yeah but these types may change maybe so I am exposing all the fields for now

@imabdulbasit @tbro
Update tag for rollup reg
dc2f5f9 
Co-authored-by: tbro <48967308+tbro@users.noreply.github.com>
@imabdulbasit imabdulbasit merged commit 6d52a7e into main Jul 31, 2024
14 checks passed
@imabdulbasit imabdulbasit deleted the ab/solver-types branch July 31, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbro tbro tbro approved these changes

@nomaxg nomaxg Awaiting requested review from nomaxg

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imabdulbasit @tbro