Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove es_version crate and use SeqTypes::Base version #1804

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

imabdulbasit
Copy link
Contributor

@imabdulbasit imabdulbasit commented Jul 31, 2024

We have consistencies where we use the es_version crate's SequencerVersion in most places, and also SeqTypes::Base version. This did not cause any issues as both versions were the same. However, updating the base version would cause some tests to fail.

This PR

  • removes es_crate completely and use SeqTypes::Base version

future work:

  • parameterize SeqTypes<Base, Upgrade> and then instantiate the sequencer at the top level with the appropriate Base and Upgrade version based on runtime configuration (e.g. genesis file) so that we are still able to run staging tests with 0.1 and 0.2 with the same binary Parameterizing Node type for Base and Upgrade version #1824
  • add message compat tests for all versions as changing base version will break them

builder/src/bin/permissionless-builder.rs Show resolved Hide resolved
builder/src/lib.rs Show resolved Hide resolved
builder/src/lib.rs Show resolved Hide resolved
@imabdulbasit imabdulbasit merged commit 8342e03 into main Aug 1, 2024
15 checks passed
@imabdulbasit imabdulbasit deleted the ab/rm-es-version branch August 1, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants