-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic builder #1810
Add generic builder #1810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@shenkeyao @elliedavidson wdyt of making reserve and fallback non-exclusive options? I.e. allowing the builder binary to be run with any combination of those? I imagine having a |
Yes, that makes sense to me. |
Sounds good! I’ll make the change. |
This reverts commit 6eafa5b.
Closes EspressoSystems/marketplace-builder-core#36.
Note: This PR is to be merged to
ag/builder-bin
and will be merged to main as part of #1806.This PR:
yaml
files.This PR does not:
Key places to review:
builder.rs
.hooks.rs
.