register rollups for native demo #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
commented
Aug 15, 2024
|
|
||
| dev-rollup: | ||
| command: | ||
| dev-rollup register --ns 1; dev-rollup register --ns 2; dev-rollup register --ns 3 |
There was a problem hiding this comment.
There might be a better name for the binary than dev-rollup. I'm also considering something like dev-rollup register --ns 1 --ns 2 --ns 3, but I'm not sure if there's a clean way to implement it and if that would be better, as each register also has other optional parameters. I might keep it as it is for now.
imabdulbasit
changed the title
imabdulbasit
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
imabdulbasit
requested review from
elliedavidson,
sveitser,
nomaxg,
jbearer,
ImJeremyHe and
tbro
and removed request for
sveitser,
philippecamacho,
nomaxg,
jbearer,
ImJeremyHe and
tbro
elliedavidson
requested changes
Aug 15, 2024
elliedavidson
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.