Small update for upgrades.md #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbro
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
imabdulbasit
as code owners
tbro
commented
Aug 16, 2024
doc/upgrades.md
Outdated
| @@ -53,7 +53,7 @@ parameters use Unix timestamps for the same purpose. | |||
|
|
|||
| To simplify configuration, these parameters are fetched from the genesis TOML file and set in the Hotshot config. The | |||
| TOML file can include either view-based parameters or time-based parameters, but not both. Furthermore, the start and | |||
| stop voting parameters for both time-based and view-based upgrades are optional. Start parameter is set 0 so that voting | |||
| stop voting parameters for both time-based and view-based upgrades are optional. Start parameter should be set 0 so that voting | |||
There was a problem hiding this comment.
Is this the correct intent?
There was a problem hiding this comment.
actually we can specify that by default it is set to 0 if not provided
imabdulbasit
approved these changes
Aug 16, 2024
imabdulbasit
requested changes
Aug 16, 2024
imabdulbasit
approved these changes
Aug 16, 2024
Co-authored-by: Abdul Basit <45506001+imabdulbasit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Updates
Upgradedocumentation for recent changes. Notably, relevant types are not associated w/ `Versions.This PR does not:
Make any changes to code.
Key places to review: