dynamic versioning #1878
Merged
dynamic versioning #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabdulbasit
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
tbro
reviewed
Aug 21, 2024
types/src/v0/mod.rs
Outdated
|
|
||
| #[derive(Debug, Copy, Clone)] | ||
| pub struct SequencerVersions; | ||
| pub type BaseV01UpgradeV02 = SequencerVersions<StaticVersion<0, 1>, StaticVersion<0, 2>>; |
There was a problem hiding this comment.
Since we are defining aliases for these, it might be a little easier to keep in sync if we use the alias everywhere.
There was a problem hiding this comment.
this is used for test network mostly
There was a problem hiding this comment.
I think I should rename it to MockSequencerVersions
tbro
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
SequencerApiVersionis currently hardcoded as V0.1 for all APIs.mainfunction torunin binaries that require a protocol version, run() accepts a generic parameter V that implements the Versions trait. This allows matching and initializing versions from the genesis.toml file using the appropriate type. This can be replaced with a macroFiles to review:
all files mostly but primary focus on genesis.toml config, SequencerVersions type and main functions in all binaries.
test:
Run the demo native locally to ensure everything functions as expected.