Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v0_1::ChainConfig::from(v0_3::ChainConfig) #1886

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

tbro
Copy link
Contributor

@tbro tbro commented Aug 22, 2024

Update committable version in sequencer and use it to coerce a v3 Commitment into a v1 commitment.

This PR:

This removes a best effort (and untested) downgrade of ChainConfig commitment in favor of using raw bytes (recently added to committable). Previously a v1 ResolvableChainConfig was derived from a v3 version using a a full cycle of serialization/de-serialization. Now that we can create a Commitment from some bytes, we can avoid that extra work. Some tests have been added to confirm expectations.

Key places to review:

  • espresso-sequencer/types/src/v0/v0_3/chain_config.rs

Update committable version in sequencer and use it to coerce a v3
Commitment into a v1 commitment.
@tbro tbro merged commit ea662d0 into main Aug 22, 2024
16 checks passed
@tbro tbro deleted the tb/chain_config_upgrade branch August 22, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants