Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test marketplace upgrade #1927

Merged
merged 11 commits into from
Sep 11, 2024
Merged

test marketplace upgrade #1927

merged 11 commits into from
Sep 11, 2024

Conversation

tbro
Copy link
Contributor

@tbro tbro commented Aug 28, 2024

Add a unit tests for marketplace view and time based upgrade. Also refactors test_upgrade_helper to support upgrades between any versions.

supersedes #1880

@tbro tbro force-pushed the tb/test-marketplace-upgrade-2 branch 2 times, most recently from 603436a to 61adfa7 Compare September 10, 2024 21:39
@tbro tbro marked this pull request as ready for review September 10, 2024 21:40
@tbro tbro force-pushed the tb/test-marketplace-upgrade-2 branch from 61adfa7 to 8cdd0bc Compare September 10, 2024 21:44
sequencer/src/lib.rs Outdated Show resolved Hide resolved
@tbro tbro enabled auto-merge (squash) September 10, 2024 22:24
Copy link
Contributor

@imabdulbasit imabdulbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we should extend both the fee and marketplace upgrade tests to check that we are producing blocks containing transactions after the upgrade.

#1996

@tbro tbro merged commit 180b99c into main Sep 11, 2024
16 checks passed
@tbro tbro deleted the tb/test-marketplace-upgrade-2 branch September 11, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants