-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test marketplace upgrade #1927
Merged
Merged
test marketplace upgrade #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbro
force-pushed
the
tb/test-marketplace-upgrade-2
branch
2 times, most recently
from
September 10, 2024 21:39
603436a
to
61adfa7
Compare
tbro
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
imabdulbasit
as code owners
September 10, 2024 21:40
tbro
force-pushed
the
tb/test-marketplace-upgrade-2
branch
from
September 10, 2024 21:44
61adfa7
to
8cdd0bc
Compare
imabdulbasit
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think we should extend both the fee and marketplace upgrade tests to check that we are producing blocks containing transactions after the upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a unit tests for marketplace view and time based upgrade. Also refactors
test_upgrade_helper
to support upgrades between any versions.supersedes #1880