Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set pipefail in demo-native action #1950

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Set pipefail in demo-native action #1950

merged 1 commit into from
Aug 30, 2024

Conversation

tbro
Copy link
Contributor

@tbro tbro commented Aug 30, 2024

This bubbles the exit status of smoke-test up to the CI runner.
Otherwise the pipe will exit w/ success since sed exits w/ 0.

@tbro
Set pipefail in shell
59a73bd 
Otherwise the pipe will exit w/ success since `set` exits w/ `0`.
@tbro tbro enabled auto-merge (squash) August 30, 2024 17:02
@tbro tbro merged commit 53f409d into main Aug 30, 2024
15 checks passed
@tbro tbro deleted the tb/fix/demo-native-fail-case branch August 30, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sveitser sveitser sveitser approved these changes

@nomaxg nomaxg Awaiting requested review from nomaxg nomaxg is a code owner

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

@imabdulbasit imabdulbasit Awaiting requested review from imabdulbasit imabdulbasit is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbro @sveitser