Fixes from Common Prefix audit of the Plonk verifier contract #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the edge case when zeta is one of the evaluation domain elements, and our lagrange coefficient (and also pi_poly_eval) is computed incorrectly. Tests are also added for these rare edge cases.
* Update script to run gas benchmarks. Store gas benchmarks for this commit. * Update lint.yml as CI is complaining.
* fix transcript and tests * fix computeChallenges in verifier * update gas benchmark * further improve and add comment to inline assembly
* Fix comment in _linearizationScalarsAndBases. * Update contracts/src/libraries/PlonkVerifier.sol Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com> --------- Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com>
* add G2 from SRS to VK and append to Transcript * update with jf
* Remove unused function _batchVerifyOpeningProofs. * Remove redundant variable sumEval. * attempt: free disk space to avoid ci failure --------- Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com>
* Gas optimization for evaluatePiPoly * add credit --------- Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com>
* use state-approach for squeeze domain-separation * memory align word size * update with merged jf
* rewrite computeChallenges in pure assembly * add more comments
* change publicInputs from dynamic to fixed array
* Remove redundant field EvalDomain.groupGenInv * Remove redundant field EvalDomain.size. * address comments --------- Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com>
* Use of constants COSET_K1,...,COSET_K4. * Put Transcript.sol and Transcript.t.sol files in some legacy folder.
* Remove unused domain sizes. * Hardcode domain elements. * removed domain.groupGen and localDomainElements. --------- Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com>
* avoid carrying around commScalars and commBases * address jakov comment on L01
Generate bindings.
philippecamacho
requested review from
nomaxg,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
philippecamacho
requested review from
alxiong
and removed request for
sveitser,
nomaxg,
jbearer,
ImJeremyHe,
imabdulbasit and
tbro
alxiong
approved these changes
Sep 3, 2024
Ticket created so we do not forget: #1973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1727
This PR:
Implements of the changes requested by Common Prefix.
This PR does not:
Note that the code in this PR still points to a branch of Jellyfish for Plonk. See
espresso-sequencer/Cargo.toml
Line 84 in d0409c8
Key places to review:
This is a quite big diff. Most changes though are related to the Plonk verifier contract.