Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return blockHeight for historical state query #2013

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Return blockHeight for historical state query #2013

merged 1 commit into from
Sep 17, 2024

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Sep 16, 2024

Mathis: The batch poster attaches what we call a justification that allows validating that the namespace is finalized by espresso. Previously it would use the height of the first hotshot root that includes the finalized block on L1 (which was returned by the function getHotShotCommitment before the changes). Since we're using an append only merkle tree I'm thinking it should work with any root after that though.

Mathis: So in this line https://github.com/EspressoSystems/nitro-espresso-integration/blob/8df6661b4449754c5a171b7f722c555da24f27ac/arbnode/batch_poster.go#L523

I think we could for example use the current height in the LC contract instead of snapshot.height

This PR:

  • Add back the hotshot block height as the returned value during getHotshotCommitment()

@alysiahuggins
Copy link
Contributor

LGTM

@sveitser sveitser merged commit ca92aaa into main Sep 17, 2024
16 checks passed
@sveitser sveitser deleted the lc-hs-comm branch September 17, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants