Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I02 - update the comments to reflect when the permissionedProver is utilized #2104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

I02 - update the comments to reflect when the permissionedProver is utilized #2104

wants to merge 1 commit into from
+9 −12

Conversation

alysiahuggins
Copy link
Contributor

@alysiahuggins alysiahuggins commented Oct 2, 2024 •
edited
Loading

Closes #2073

This PR:

  • instead of making the permissionedProver mandatory when initializing the contract, it updates the comments to reflect the fact that permissionedProver mode is a toggle

Key places to review:

  • wherever permissionedProver is mentioned

@alysiahuggins alysiahuggins linked an issue Oct 2, 2024 that may be closed by this pull request
I02: Misleading documentation #2073
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomaxg nomaxg Awaiting requested review from nomaxg nomaxg is a code owner

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

@tbro tbro Awaiting requested review from tbro tbro is a code owner

@imabdulbasit imabdulbasit Awaiting requested review from imabdulbasit imabdulbasit is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I02: Misleading documentation
1 participant
@alysiahuggins