Reduce max_blocks in the commit task if we exceed the block gas limit #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomaxg
requested review from
philippecamacho,
ImJeremyHe,
sveitser and
jbearer
as code owners
jbearer
approved these changes
Dec 20, 2023
…that we can increase if we succeed Signed-off-by: nomaxg <noahgolub2@gmail.com>
nomaxg
commented
Dec 21, 2023
jbearer
reviewed
Dec 21, 2023
| .block_height() | ||
| .call() | ||
| .await | ||
| .map_err(|e| SyncError::Other(e.into()))? |
There was a problem hiding this comment.
Nit: implement From<anyhow::Error> for SyncError and you can just use ? without this map_err
There was a problem hiding this comment.
But this underlying error isn't an anyhow:Error, so we'd still need to do a double mapping somehow right?
Signed-off-by: nomaxg <noahgolub2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #857