Add a program to submit random transactions #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
requested review from
nomaxg,
philippecamacho,
ImJeremyHe and
sveitser
as code owners
sveitser
reviewed
Dec 26, 2023
| #[clap(short, long, default_value = "1")] | ||
| jobs: usize, | ||
|
|
||
| /// URL of the query service. |
There was a problem hiding this comment.
This doesn't have the clap derive. What does that do?
There was a problem hiding this comment.
Makes it a (required) positional argument
sveitser
reviewed
Dec 26, 2023
| fn random_transaction(min_size: usize, max_size: usize) -> Transaction { | ||
| let mut rng = thread_rng(); | ||
|
|
||
| let vm = rng.next_u64(); |
There was a problem hiding this comment.
Wondering if we want to narrow this down to a few VM IDs instead of sampling from the whole range which means we will probably never use the same VM ID twice.
sveitser
reviewed
Dec 26, 2023
| } | ||
|
|
||
| fn random_transaction(min_size: usize, max_size: usize) -> Transaction { | ||
| let mut rng = thread_rng(); |
There was a problem hiding this comment.
How does this work with multithreading? It might be nice to allow passing in a seed to make the generated transactions deterministic, but we can also add that later.
edit: first question answered here: https://rust-random.github.io/book/guide-parallel.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.