Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local demo #911

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Fix local demo #911

merged 2 commits into from
Dec 29, 2023

Conversation

jbearer
Copy link
Member

@jbearer jbearer commented Dec 28, 2023

  • Do not set HotShot contract address. This causes the commitment task to ignore the --deploy flag and use an address which has no contract deployed
  • Add healthchecks to codify startup order for native demo

@jbearer
Fix local demo
a24f132 
* Do not set HotShot contract address. This causes the commitment
  task to ignore the --deploy flag and use an address which has no
  contract deployed
* Add healthchecks to codify startup order for native demo
@philippecamacho
Copy link
Contributor

How can we check that the demo works properly?
I ran just demo-native and I get this screen:

image

@sveitser
Copy link
Collaborator

It should look something like this:

image

sveitser
sveitser approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@sveitser sveitser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philippecamacho
Copy link
Contributor

It should look something like this:

Is this normal? (Looks like the commitment task cannot start)

image

image

image

@sveitser
Copy link
Collaborator

@philippecamacho the logs mention something about a duplicate docker network so I would remove the docker networks (docker network rm espresso-sequencer) and try again.

@philippecamacho
Copy link
Contributor

docker network rm espresso-sequencer

Thanks!

philippecamacho
philippecamacho approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@philippecamacho philippecamacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbearer jbearer merged commit 6f3bf10 into main Dec 29, 2023
9 checks passed
@jbearer jbearer deleted the fix/native-demo branch December 29, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sveitser sveitser sveitser approved these changes

@philippecamacho philippecamacho philippecamacho approved these changes

@nomaxg nomaxg Awaiting requested review from nomaxg nomaxg is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbearer @philippecamacho @sveitser