Optimize verifier eq #102
Merged
Optimize verifier eq #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperplonk/src/mock.rs
Outdated
| @@ -85,10 +86,11 @@ impl<F: PrimeField> MockCircuit<F> { | |||
| witnesses[i].append(cur_witness[i]); | |||
| } | |||
| } | |||
| let public_inputs=witnesses[0].0[0..4].to_vec(); | |||
There was a problem hiding this comment.
pub_inp_len should be min(4, num_constraints).
hyperplonk/src/mock.rs
Outdated
| @@ -144,7 +146,7 @@ mod test { | |||
|
|
|||
| const SUPPORTED_SIZE: usize = 20; | |||
| const MIN_NUM_VARS: usize = 8; | |||
| const MAX_NUM_VARS: usize = 15; | |||
| const MAX_NUM_VARS: usize = 19; | |||
There was a problem hiding this comment.
I set it to 15 to decrease test time
chancharles92
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the verifier by directly evaluating eq instead of building the entire table. Also enabled public inputs that are smaller than a witness column. Only supports power of 2 public inputs.
For mu=19
Fixing EQ: 137.558ms -> 44.067ms
Fixing public inputs 44.067ms->20.560ms
close #100