Improve sum check in general and preprocess for sum check in mlkzg multi_open
#123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 changes:
products.len() +1
points instead of alwaysmax_degree + 1
points, and extrapolate it tomax_degree + 1
points later.multi_open
to combine the polys opening at the same point, to reduce the workload of updating the table.Comparison
Running
cargo bench --bench hyperplonk-benches --features print-trace
and extract the following trace components ofbench_vanilla_plonk
whennum_vars = 20
, the result is as follows:compute tilde eq for 22 points
sum check prove of 20 variables
100.478ms
991.671ms
69.953ms
235.245ms