Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move transcript to trait #46

Merged
merged 3 commits into from
Jul 26, 2022
Merged

move transcript to trait #46

merged 3 commits into from
Jul 26, 2022

Conversation

zhenfeizhang
Copy link
Contributor

No description provided.

@zhenfeizhang zhenfeizhang marked this pull request as ready for review July 26, 2022 14:24
chancharles92
chancharles92 reviewed Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@chancharles92 chancharles92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but line 240 of pcs/src/multilinear_kzg/batching.rs has a clippy warning.

@zhenfeizhang zhenfeizhang mentioned this pull request Jul 26, 2022
Merged
@zhenfeizhang zhenfeizhang merged commit 229148e into main Jul 26, 2022
@zhenfeizhang zhenfeizhang deleted the impl_transcript_trait branch July 26, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancharles92 chancharles92 chancharles92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenfeizhang @chancharles92