New batch opening #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenfeizhang
changed the base branch from
main
to
optimize-selector-batch-opening
| @@ -203,6 +203,28 @@ pub(crate) fn generate_evaluations_single_poly<F: PrimeField>( | |||
| Ok(mle_values) | |||
| } | |||
|
|
|||
| /// Generate eq(t,x), a product of multilinear polynomials with fixed t. | |||
There was a problem hiding this comment.
Why do we need a vector of polys? Rather than only a single poly?
hyperplonk/src/batching.rs
Outdated
| /// Steps: | ||
| /// 1. todo... | ||
| pub(crate) fn multi_open_internal<E: PairingEngine>( | ||
| uni_prover_param: UnivariateProverParam<E::G1Affine>, |
There was a problem hiding this comment.
this is unnecessary anymore.
hyperplonk/src/batching.rs
Outdated
| )); | ||
|
|
||
| // commit to tilde g | ||
| let tilde_g_commit = MultilinearKzgPCS::commit(&(ml_prover_param, uni_prover_param), &tilde_g)?; |
hyperplonk/src/batching.rs
Outdated
| let tilde_g_commit = MultilinearKzgPCS::commit(&(ml_prover_param, uni_prover_param), &tilde_g)?; | ||
|
|
||
| // \tilde eq is the concat of all points, padded with 0s | ||
| let mut tilde_eq_eval = points.iter().flatten().copied().collect::<Vec<E::Fr>>(); |
There was a problem hiding this comment.
this is different from tilde_eq_eval in the paper.
| end_timer!(step); | ||
|
|
||
| let proof = <PolyIOP<E::Fr> as SumCheck<E::Fr>>::prove(&sum_check_vp, transcript)?; | ||
| let tilde_g_eval = tilde_g.evaluate(&proof.point).unwrap(); |
There was a problem hiding this comment.
do we need this step? can't tilde_g_eval be obtained from sumcheck_proof?
|
closed in favor of #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.